Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorization #109

Closed
wants to merge 4 commits into from
Closed

Authorization #109

wants to merge 4 commits into from

Conversation

hbcarlos
Copy link
Contributor

@hbcarlos hbcarlos commented Oct 27, 2021 •
edited
Loading

Solves #44

For now, it is only a draft PR that solved some bugs with the Authentication and federated extensions.

Bug fixed:

  • Remove dependency get_auth_config from create_guest.
  • Support disabling extensions
  • Reload federated extensions
  • Adds field connected to users (I removed in my last PR, I thought wasn't necessary. It is)
  • Changes users endpoint to collaborators and filters the active user
  • Improves login page (Press enter to login by token)
  • Dependency get_current_user selects user by token when using token mode

TODO:

  • Add roles
    • ADMIN, READ, WRITE, RUN
  • Allow registering anonymous users in token mode
  • Create authorization dependency
  • Add authorization dependency to all routes

@hbcarlos hbcarlos marked this pull request as draft October 27, 2021 15:11
@davidbrochart
Copy link
Collaborator

Some of the changes in a0cabe2 and fd93a16 have been merged in #124.

@davidbrochart
Copy link
Collaborator

@hbcarlos I think this PR was superseded by #206. If not, feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbcarlos @davidbrochart